소스 검색

! Refactoring code documentation in standard style. (several files)
! Moving a compatibility function met on the way to Subs-Compat.php. (crc32)

Spuds 12 년 전
부모
커밋
48d33e84ff
10개의 변경된 파일619개의 추가작업 그리고 569개의 파일을 삭제
  1. 36 38
      Sources/Admin.php
  2. 13 16
      Sources/BoardIndex.php
  3. 28 30
      Sources/Calendar.php
  4. 10 25
      Sources/Class-Graphics.php
  5. 354 313
      Sources/Class-Package.php
  6. 40 41
      Sources/DbExtra-mysql.php
  7. 40 41
      Sources/DbExtra-postgresql.php
  8. 44 42
      Sources/DbExtra-sqlite.php
  9. 11 14
      Sources/DumpDatabase.php
  10. 43 9
      Sources/Subs-Compat.php

+ 36 - 38
Sources/Admin.php

@@ -1,6 +1,8 @@
 <?php
 
 /**
+ * This file, unpredictable as this might be, handles basic administration.
+ *
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -15,37 +17,12 @@
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	This file, unpredictable as this might be, handles basic administration.
-
-	void AdminMain()
-		- initialises all the basic context required for the admin center.
-		- passes execution onto the relevant admin section.
-		- if the passed section is not found it shows the admin home page.
-
-	void AdminHome()
-		- prepares all the data necessary for the administration front page.
-		- uses the Admin template along with the admin sub template.
-		- requires the moderate_forum, manage_membergroups, manage_bans,
-		  admin_forum, manage_permissions, manage_attachments, manage_smileys,
-		  manage_boards, edit_news, or send_mail permission.
-		- uses the index administrative area.
-		- can be found by going to ?action=admin.
-
-	void AdminSearch()
-		- allocates out all the search stuff.
-
-	void AdminSearchInternal()
-		- a complicated but relatively quick internal search.
-
-	void AdminSearchMember()
-		- pass through to manage members.
-
-	void DisplayAdminFile()
-		- get one of the admin information files from Simple Machines.
-
-*/
-
-// The main admin handling function.
+/**
+ * The main admin handling function.
+ * It initialises all the basic context required for the admin center.
+ * It passes execution onto the relevant admin section.
+ * If the passed section is not found it shows the admin home page.
+ */
 function AdminMain()
 {
 	global $txt, $context, $scripturl, $sc, $modSettings, $user_info, $settings, $sourcedir, $options, $smcFunc, $boarddir;
@@ -505,7 +482,16 @@ function AdminMain()
 	$admin_include_data['function']();
 }
 
-// The main administration section.
+/**
+ * The main administration section.
+ * It prepares all the data necessary for the administration front page.
+ * It uses the Admin template along with the admin sub template.
+ * It requires the moderate_forum, manage_membergroups, manage_bans,
+ *  admin_forum, manage_permissions, manage_attachments, manage_smileys,
+ *  manage_boards, edit_news, or send_mail permission.
+ *  It uses the index administrative area.
+ *  It can be found by going to ?action=admin.
+*/
 function AdminHome()
 {
 	global $sourcedir, $forum_version, $txt, $scripturl, $context, $user_info, $boardurl, $modSettings, $smcFunc;
@@ -618,7 +604,9 @@ function AdminHome()
 	);
 }
 
-// Get one of the admin information files from Simple Machines.
+/**
+ * Get one of the admin information files from Simple Machines.
+ */
 function DisplayAdminFile()
 {
 	global $context, $modSettings, $smcFunc;
@@ -666,7 +654,9 @@ if (!(\'smfForum_sessionvar\' in window))
 	obExit(false);
 }
 
-// This allocates out all the search stuff.
+/**
+ * This function allocates out all the search stuff.
+ */
 function AdminSearch()
 {
 	global $txt, $context, $smcFunc, $sourcedir;
@@ -702,7 +692,9 @@ function AdminSearch()
 		$subactions[$context['search_type']]();
 }
 
-// A complicated but relatively quick internal search.
+/**
+ * A complicated but relatively quick internal search.
+ */
 function AdminSearchInternal()
 {
 	global $context, $txt, $helptxt, $scripturl, $sourcedir;
@@ -840,7 +832,9 @@ function AdminSearchInternal()
 	}
 }
 
-// All this does is pass through to manage members.
+/**
+ * All this does is pass through to manage members.
+ */
 function AdminSearchMember()
 {
 	global $context, $sourcedir;
@@ -853,7 +847,9 @@ function AdminSearchMember()
 	ViewMembers();
 }
 
-// This file allows the user to search the SM online manual for a little of help.
+/**
+ * This file allows the user to search the SM online manual for a little of help.
+ */
 function AdminSearchOM()
 {
 	global $context, $sourcedir;
@@ -940,7 +936,9 @@ function AdminSearchOM()
 	}
 }
 
-// This function decides which log to load.
+/**
+ * This function decides which log to load.
+ */
 function AdminLogs()
 {
 	global $sourcedir, $context, $txt, $scripturl;

+ 13 - 16
Sources/BoardIndex.php

@@ -1,6 +1,9 @@
 <?php
 
 /**
+ * The single function this file contains is used to display the main
+ * board index.
+ *
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -14,21 +17,13 @@
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	The single function this file contains is used to display the main
-	board index.  It uses just the following functions:
-
-	void BoardIndex()
-		- shows the board index.
-		- uses the BoardIndex template, and main sub template.
-		- may use the boardindex subtemplate for wireless support.
-		- updates the most online statistics.
-		- is accessed by ?action=boardindex.
-
-	void CollapseCategory()
-		- collapse or expand a category
-*/
-
-// Show the board index!
+/**
+ * This function shows the board index.
+ * It uses the BoardIndex template, and main sub template.
+ * It may use the boardindex subtemplate for wireless support.
+ * It updates the most online statistics.
+ * It is accessed by ?action=boardindex.
+ */
 function BoardIndex()
 {
 	global $txt, $user_info, $sourcedir, $modSettings, $context, $settings, $scripturl;
@@ -115,7 +110,9 @@ function BoardIndex()
 	$context['page_title'] = sprintf($txt['forum_index'], $context['forum_name']);
 }
 
-// Collapse or expand a category
+/**
+ * Collapse or expand a category
+ */
 function CollapseCategory()
 {
 	global $user_info, $sourcedir, $context;

+ 28 - 30
Sources/Calendar.php

@@ -1,6 +1,9 @@
 <?php
 
 /**
+ * This file has only one real task, showing the calendar.
+ * Original module by Aaron O'Neil - [email protected]
+ *
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -11,38 +14,19 @@
  * @version 2.0
  */
 
-// Original module by Aaron O'Neil - [email protected]
-
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	This file has only one real task... showing the calendar.  Posting is done
-	in Post.php - this just has the following functions:
-
-	void CalendarMain()
-		- loads the specified month's events, holidays, and birthdays.
-		- requires the calendar_view permission.
-		- depends on the cal_enabled setting, and many of the other cal_
-		  settings.
-		- uses the calendar_start_day theme option. (Monday/Sunday)
-		- uses the main sub template in the Calendar template.
-		- goes to the month and year passed in 'month' and 'year' by
-		  get or post.
-		- accessed through ?action=calendar.
-
-	void CalendarPost()
-		- processes posting/editing/deleting a calendar event.
-		- calls Post() function if event is linked to a post.
-		- calls insertEvent() to insert the event if not linked to post.
-		- requires the calendar_post permission to use.
-		- uses the event_post sub template in the Calendar template.
-		- is accessed with ?action=calendar;sa=post.
-
-	void iCalDownload()
-		- offers up a download of an event in iCal 2.0 format.
-*/
-
-// Show the calendar.
+/**
+ * Show the calendar.
+ * It loads the specified month's events, holidays, and birthdays.
+ * It requires the calendar_view permission.
+ * It depends on the cal_enabled setting, and many of the other cal_ settings.
+ * It uses the calendar_start_day theme option. (Monday/Sunday)
+ * It uses the main sub template in the Calendar template.
+ * It goes to the month and year passed in 'month' and 'year' by get or post.
+ * It is accessed through ?action=calendar.
+ */
 function CalendarMain()
 {
 	global $txt, $context, $modSettings, $scripturl, $options, $sourcedir;
@@ -162,6 +146,14 @@ function CalendarMain()
 		);
 }
 
+/**
+ * This function processes posting/editing/deleting a calendar event.
+ * 	- calls Post() function if event is linked to a post.
+ *  - calls insertEvent() to insert the event if not linked to post.
+ * It requires the calendar_post permission to use.
+ * It uses the event_post sub template in the Calendar template.
+ * It is accessed with ?action=calendar;sa=post.
+ */
 function CalendarPost()
 {
 	global $context, $txt, $user_info, $sourcedir, $scripturl;
@@ -308,6 +300,10 @@ function CalendarPost()
 	);
 }
 
+/**
+ * This function offers up a download of an event in iCal 2.0 format.
+ * @todo lol... User interface! :P
+ */
 function iCalDownload()
 {
 	global $smcFunc, $sourcedir, $forum_version, $context, $modSettings;
@@ -382,7 +378,9 @@ function iCalDownload()
 	obExit(false);
 }
 
-// This is not the code you are looking for.
+/**
+ * Nothing to see here. Move along.
+ */
 function clock()
 {
 	global $settings, $context;

+ 10 - 25
Sources/Class-Graphics.php

@@ -1,6 +1,14 @@
 <?php
 
 /**
+ * Classes used for reading gif files (in case PHP's GD doesn't provide the
+ * proper gif-functions).
+ *
+ * Gif Util copyright 2003 by Yamasoft (S/C). All rights reserved.
+ * Do not remove this portion of the header, or use these functions except
+ * from the original author. To get it, please navigate to:
+ * http://www.yamasoft.com/php-gif.zip
+ *
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -11,19 +19,9 @@
  * @version 2.0
  */
 
-/*	Gif Util copyright 2003 by Yamasoft (S/C). All rights reserved.
-	Do not remove this portion of the header, or use these functions except
-	from the original author. To get it, please navigate to:
-	http://www.yamasoft.com/php-gif.zip
-*/
-
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	Classes used for reading gif files (in case PHP's GD doesn't provide the
-	proper gif-functions).
-*/
-
 class gif_lzw_compression
 {
 	public $MAX_LZW_BITS;
@@ -693,23 +691,10 @@ class gif_file
 	}
 }
 
-// crc32 doesn't work as expected on 64-bit functions - make our own.
-// http://www.php.net/crc32#79567
+// 64-bit only functions?
 if (!function_exists('smf_crc32'))
 {
-	function smf_crc32($number)
-	{
-		$crc = crc32($number);
-
-		if ($crc & 0x80000000)
-		{
-			$crc ^= 0xffffffff;
-			$crc += 1;
-			$crc = -$crc;
-		}
-
-		return $crc;
-	}
+	include $sourcedir . '/Subs-Compat.php';
 }
 
 ?>

+ 354 - 313
Sources/Class-Package.php

@@ -1,6 +1,8 @@
 <?php
 
 /**
+ * The xmlArray class is an xml parser.
+ *
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -14,20 +16,7 @@
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	The following functions are all within the xmlArray class, which is the xml
-	parser.  There are more functions, but these are the ones that should be
-	used from outside the class:
-
-	class xmlArray(string data, bool auto_trim = false,
-			int error_level = error_reporting(), bool is_clone = false)
-		- creates a new xmlArray, which is an simple xml dom parser.
-		- data should be the xml data or an array of, unless is_clone is true.
-		- auto_trim can be used to automatically trim textual data.
-		- error_level specifies whether notices should be generated for
-		  missing elements and attributes.
-		- if is_clone is true, the xmlArray is cloned from another - used
-		  internally only.
-
+/*
 	string xmlArray::name()
 		- retrieves the name of the current element, usually ''.
 
@@ -63,9 +52,17 @@ class xmlArray
 	// The array and debugging output level.
 	public $array, $debug_level, $trim;
 
-	// Create an xml array.
-	//	the xml data, trim elements?, debugging output level, reserved.
-	//ie. $xml = new xmlArray(file('data.xml'));
+	/**
+	 * Constructor for the xml parser.
+	 * Example use:
+	 *  $xml = new xmlArray(file('data.xml'));
+	 * @param $data string the xml data or an array of, unless is_clone is true.
+	 * @param $auto_trim bool, default false, used to automatically trim textual data.
+	 * @param $level int, default null, the debug level, specifies whether notices
+	 *  should be generated for missing elements and attributes.
+	 * @param $is_clone bool, default false. If is_clone is true, the
+	 *  xmlArray is cloned from another - used internally only.
+	 */
 	public function __construct($data, $auto_trim = false, $level = null, $is_clone = false)
 	{
 		// If we're using this try to get some more memory.
@@ -93,16 +90,23 @@ class xmlArray
 		$this->array = $this->_parse($data);
 	}
 
-	// Get the root element's name.
-	//ie. echo $element->name();
+	/**
+	 * Get the root element's name.
+	 * Example use:
+	 *  echo $element->name();
+	 */
 	public function name()
 	{
 		return isset($this->array['name']) ? $this->array['name'] : '';
 	}
 
-	// Get a specified element's value or attribute by path.
-	//	the path to the element to fetch, whether to include elements?
-	//ie. $data = $xml->fetch('html/head/title');
+	/**
+	 * Get a specified element's value or attribute by path.
+	 * Example use:
+	 *  $data = $xml->fetch('html/head/title');
+	 * @param $path string - the path to the element to fetch
+	 * @param $get_elements - whether to include elements
+	 */
 	public function fetch($path, $get_elements = false)
 	{
 		// Get the element, in array form.
@@ -132,9 +136,12 @@ class xmlArray
 		return is_string($array) ? $array : $this->_fetch($array->array);
 	}
 
-	// Get an element, returns a new xmlArray.
-	//	the path to the element to get, always return full result set? (ie. don't contract a single item.)
-	//ie. $element = $xml->path('html/body');
+	/** Get an element, returns a new xmlArray.
+	 * Example use:
+	 *  $element = $xml->path('html/body');
+	 * @param $path string - the path to the element to get
+	 * @param $return_full bool - always return full result set
+	 */
 	public function path($path, $return_full = false)
 	{
 		// Split up the path.
@@ -195,9 +202,12 @@ class xmlArray
 		return $array === false ? false : new $newClass($array, $this->trim, $this->debug_level, true);
 	}
 
-	// Check if an element exists.
-	//	the path to the element to get.
-	//ie. echo $xml->exists('html/body') ? 'y' : 'n';
+	/**
+	 * Check if an element exists.
+	 * Example use,
+	 *  echo $xml->exists('html/body') ? 'y' : 'n';
+	 * @param $path string - the path to the element to get.
+	 */
 	public function exists($path)
 	{
 		// Split up the path.
@@ -228,9 +238,12 @@ class xmlArray
 		return $array !== false;
 	}
 
-	// Count the number of occurances of a path.
-	//	the path to search for.
-	//ie. echo $xml->count('html/head/meta');
+	/**
+	 * Count the number of occurances of a path.
+	 * Example use:
+	 *  echo $xml->count('html/head/meta');
+	 * @param $path string - the path to search for.
+	 */
 	public function count($path)
 	{
 		// Get the element, always returning a full set.
@@ -247,9 +260,12 @@ class xmlArray
 		return $i;
 	}
 
-	// Get an array of xmlArray's for use with foreach.
-	//	the path to search for.
-	//ie. foreach ($xml->set('html/body/p') as $p)
+	/**
+	 * Get an array of xmlArray's for use with foreach.
+	 * Example use:
+	 *  foreach ($xml->set('html/body/p') as $p)
+	 * @param $path string - the path to search for.
+	 */
 	public function set($path)
 	{
 		// None as yet, just get the path.
@@ -272,9 +288,12 @@ class xmlArray
 		return $array;
 	}
 
-	// Create an xml file from an xml array.
-	//	the path to the element. (optional)
-	//ie. echo $this->create_xml()
+	/**
+	 * Create an xml file from an xml array.
+	 * Example use:
+	 *  echo $this->create_xml();
+	 * @param $path string - the path to the element. (optional)
+	 */
 	public function create_xml($path = null)
 	{
 		// Was a path specified?  If so, use that array.
@@ -296,9 +315,12 @@ class xmlArray
 		return '<?xml version="1.0"?' . '>' . $this->_xml($path, 0);
 	}
 
-	// Output the xml in an array form.
-	//	the path to output.
-	//ie. print_r($xml->to_array());
+	/**
+	 * Output the xml in an array form.
+	 * Example use:
+	 *  print_r($xml->to_array());
+	 * @param $path string, the path to output.
+	 */
 	public function to_array($path = null)
 	{
 		// Are we doing a specific path?
@@ -319,7 +341,10 @@ class xmlArray
 		return $this->_array($path);
 	}
 
-	// Parse data into an array. (privately used...)
+	/**
+	 * Parse data into an array. (privately used...)
+	 * @param $data string to parse
+	 */
 	protected function _parse($data)
 	{
 		// Start with an 'empty' array with no data.
@@ -463,7 +488,11 @@ class xmlArray
 		return $current;
 	}
 
-	// Get a specific element's xml. (privately used...)
+	/**
+	 * Get a specific element's xml. (privately used...)
+	 * @param $array
+	 * @param $indent
+	 */
 	protected function _xml($array, $indent)
 	{
 		$indentation = $indent !== null ? '
@@ -533,7 +562,10 @@ class xmlArray
 			return $return;
 	}
 
-	// Parse out CDATA tags. (htmlspecialchars them...)
+	/**
+	 * Parse out CDATA tags. (htmlspecialchars them...)
+	 * @param $data
+	 */
 	function _to_cdata($data)
 	{
 		$inCdata = $inComment = false;
@@ -566,7 +598,10 @@ class xmlArray
 		return $output;
 	}
 
-	// Turn the CDATAs back to normal text.
+	/**
+	 * Turn the CDATAs back to normal text.
+	 * @param $data
+	 */
 	protected function _from_cdata($data)
 	{
 		// Get the HTML translation table and reverse it.
@@ -604,7 +639,13 @@ class xmlArray
 		return $temp;
 	}
 
-	// Get a specific array by path, one level down. (privately used...)
+	/**
+	 * Get a specific array by path, one level down. (privately used...)
+	 * @param $array
+	 * @param $path
+	 * @param $level
+	 * @param $no_error
+	 */
 	protected function _path($array, $path, $level, $no_error = false)
 	{
 		// Is $array even an array?  It might be false!
@@ -665,354 +706,354 @@ class xmlArray
 	}
 }
 
-// http://www.faqs.org/rfcs/rfc959.html
-if (!class_exists('ftp_connection'))
+/**
+ * Simple FTP protocol implementation.
+ * http://www.faqs.org/rfcs/rfc959.html
+ */
+class ftp_connection
 {
-	class ftp_connection
+	public $connection, $error, $last_message, $pasv;
+
+	// Create a new FTP connection...
+	public function __construct($ftp_server, $ftp_port = 21, $ftp_user = 'anonymous', $ftp_pass = '[email protected]')
 	{
-		public $connection, $error, $last_message, $pasv;
+		// Initialize variables.
+		$this->connection = 'no_connection';
+		$this->error = false;
+		$this->pasv = array();
+
+		if ($ftp_server !== null)
+			$this->connect($ftp_server, $ftp_port, $ftp_user, $ftp_pass);
+	}
 
-		// Create a new FTP connection...
-		public function __construct($ftp_server, $ftp_port = 21, $ftp_user = 'anonymous', $ftp_pass = '[email protected]')
+	public function connect($ftp_server, $ftp_port = 21, $ftp_user = 'anonymous', $ftp_pass = '[email protected]')
+	{
+		if (substr($ftp_server, 0, 6) == 'ftp://')
+			$ftp_server = substr($ftp_server, 6);
+		elseif (substr($ftp_server, 0, 7) == 'ftps://')
+			$ftp_server = 'ssl://' . substr($ftp_server, 7);
+		if (substr($ftp_server, 0, 7) == 'http://')
+			$ftp_server = substr($ftp_server, 7);
+		$ftp_server = strtr($ftp_server, array('/' => '', ':' => '', '@' => ''));
+
+		// Connect to the FTP server.
+		$this->connection = @fsockopen($ftp_server, $ftp_port, $err, $err, 5);
+		if (!$this->connection)
 		{
-			// Initialize variables.
-			$this->connection = 'no_connection';
-			$this->error = false;
-			$this->pasv = array();
+			$this->error = 'bad_server';
+			return;
+		}
 
-			if ($ftp_server !== null)
-				$this->connect($ftp_server, $ftp_port, $ftp_user, $ftp_pass);
+		// Get the welcome message...
+		if (!$this->check_response(220))
+		{
+			$this->error = 'bad_response';
+			return;
 		}
 
-		public function connect($ftp_server, $ftp_port = 21, $ftp_user = 'anonymous', $ftp_pass = '[email protected]')
+		// Send the username, it should ask for a password.
+		fwrite($this->connection, 'USER ' . $ftp_user . "\r\n");
+		if (!$this->check_response(331))
 		{
-			if (substr($ftp_server, 0, 6) == 'ftp://')
-				$ftp_server = substr($ftp_server, 6);
-			elseif (substr($ftp_server, 0, 7) == 'ftps://')
-				$ftp_server = 'ssl://' . substr($ftp_server, 7);
-			if (substr($ftp_server, 0, 7) == 'http://')
-				$ftp_server = substr($ftp_server, 7);
-			$ftp_server = strtr($ftp_server, array('/' => '', ':' => '', '@' => ''));
+			$this->error = 'bad_username';
+			return;
+		}
 
-			// Connect to the FTP server.
-			$this->connection = @fsockopen($ftp_server, $ftp_port, $err, $err, 5);
-			if (!$this->connection)
-			{
-				$this->error = 'bad_server';
-				return;
-			}
+		// Now send the password... and hope it goes okay.
+		fwrite($this->connection, 'PASS ' . $ftp_pass . "\r\n");
+		if (!$this->check_response(230))
+		{
+			$this->error = 'bad_password';
+			return;
+		}
+	}
 
-			// Get the welcome message...
-			if (!$this->check_response(220))
-			{
-				$this->error = 'bad_response';
-				return;
-			}
+	public function chdir($ftp_path)
+	{
+		if (!is_resource($this->connection))
+			return false;
 
-			// Send the username, it should ask for a password.
-			fwrite($this->connection, 'USER ' . $ftp_user . "\r\n");
-			if (!$this->check_response(331))
-			{
-				$this->error = 'bad_username';
-				return;
-			}
+		// No slash on the end, please...
+		if ($ftp_path !== '/' && substr($ftp_path, -1) === '/')
+			$ftp_path = substr($ftp_path, 0, -1);
 
-			// Now send the password... and hope it goes okay.
-			fwrite($this->connection, 'PASS ' . $ftp_pass . "\r\n");
-			if (!$this->check_response(230))
-			{
-				$this->error = 'bad_password';
-				return;
-			}
+		fwrite($this->connection, 'CWD ' . $ftp_path . "\r\n");
+		if (!$this->check_response(250))
+		{
+			$this->error = 'bad_path';
+			return false;
 		}
 
-		public function chdir($ftp_path)
-		{
-			if (!is_resource($this->connection))
-				return false;
+		return true;
+	}
 
-			// No slash on the end, please...
-			if ($ftp_path !== '/' && substr($ftp_path, -1) === '/')
-				$ftp_path = substr($ftp_path, 0, -1);
+	public function chmod($ftp_file, $chmod)
+	{
+		if (!is_resource($this->connection))
+			return false;
 
-			fwrite($this->connection, 'CWD ' . $ftp_path . "\r\n");
-			if (!$this->check_response(250))
-			{
-				$this->error = 'bad_path';
-				return false;
-			}
+		if ($ftp_file == '')
+			$ftp_file = '.';
 
-			return true;
+		// Convert the chmod value from octal (0777) to text ("777").
+		fwrite($this->connection, 'SITE CHMOD ' . decoct($chmod) . ' ' . $ftp_file . "\r\n");
+		if (!$this->check_response(200))
+		{
+			$this->error = 'bad_file';
+			return false;
 		}
 
-		public function chmod($ftp_file, $chmod)
-		{
-			if (!is_resource($this->connection))
-				return false;
+		return true;
+	}
 
-			if ($ftp_file == '')
-				$ftp_file = '.';
+	public function unlink($ftp_file)
+	{
+		// We are actually connected, right?
+		if (!is_resource($this->connection))
+			return false;
+
+		// Delete file X.
+		fwrite($this->connection, 'DELE ' . $ftp_file . "\r\n");
+		if (!$this->check_response(250))
+		{
+			fwrite($this->connection, 'RMD ' . $ftp_file . "\r\n");
 
-			// Convert the chmod value from octal (0777) to text ("777").
-			fwrite($this->connection, 'SITE CHMOD ' . decoct($chmod) . ' ' . $ftp_file . "\r\n");
-			if (!$this->check_response(200))
+			// Still no love?
+			if (!$this->check_response(250))
 			{
 				$this->error = 'bad_file';
 				return false;
 			}
-
-			return true;
 		}
 
-		public function unlink($ftp_file)
-		{
-			// We are actually connected, right?
-			if (!is_resource($this->connection))
-				return false;
+		return true;
+	}
 
-			// Delete file X.
-			fwrite($this->connection, 'DELE ' . $ftp_file . "\r\n");
-			if (!$this->check_response(250))
-			{
-				fwrite($this->connection, 'RMD ' . $ftp_file . "\r\n");
+	public function check_response($desired)
+	{
+		// Wait for a response that isn't continued with -, but don't wait too long.
+		$time = time();
+		do
+			$this->last_message = fgets($this->connection, 1024);
+		while ((strlen($this->last_message) < 4 || substr($this->last_message, 0, 1) == ' ' || substr($this->last_message, 3, 1) != ' ') && time() - $time < 5);
+
+		// Was the desired response returned?
+		return is_array($desired) ? in_array(substr($this->last_message, 0, 3), $desired) : substr($this->last_message, 0, 3) == $desired;
+	}
 
-				// Still no love?
-				if (!$this->check_response(250))
-				{
-					$this->error = 'bad_file';
-					return false;
-				}
-			}
+	public function passive()
+	{
+		// We can't create a passive data connection without a primary one first being there.
+		if (!is_resource($this->connection))
+			return false;
 
-			return true;
-		}
+		// Request a passive connection - this means, we'll talk to you, you don't talk to us.
+		@fwrite($this->connection, 'PASV' . "\r\n");
+		$time = time();
+		do
+			$response = fgets($this->connection, 1024);
+		while (substr($response, 3, 1) != ' ' && time() - $time < 5);
 
-		public function check_response($desired)
+		// If it's not 227, we weren't given an IP and port, which means it failed.
+		if (substr($response, 0, 4) != '227 ')
 		{
-			// Wait for a response that isn't continued with -, but don't wait too long.
-			$time = time();
-			do
-				$this->last_message = fgets($this->connection, 1024);
-			while ((strlen($this->last_message) < 4 || substr($this->last_message, 0, 1) == ' ' || substr($this->last_message, 3, 1) != ' ') && time() - $time < 5);
-
-			// Was the desired response returned?
-			return is_array($desired) ? in_array(substr($this->last_message, 0, 3), $desired) : substr($this->last_message, 0, 3) == $desired;
+			$this->error = 'bad_response';
+			return false;
 		}
 
-		public function passive()
+		// Snatch the IP and port information, or die horribly trying...
+		if (preg_match('~\((\d+),\s*(\d+),\s*(\d+),\s*(\d+),\s*(\d+)(?:,\s*(\d+))\)~', $response, $match) == 0)
 		{
-			// We can't create a passive data connection without a primary one first being there.
-			if (!is_resource($this->connection))
-				return false;
+			$this->error = 'bad_response';
+			return false;
+		}
 
-			// Request a passive connection - this means, we'll talk to you, you don't talk to us.
-			@fwrite($this->connection, 'PASV' . "\r\n");
-			$time = time();
-			do
-				$response = fgets($this->connection, 1024);
-			while (substr($response, 3, 1) != ' ' && time() - $time < 5);
+		// This is pretty simple - store it for later use ;).
+		$this->pasv = array('ip' => $match[1] . '.' . $match[2] . '.' . $match[3] . '.' . $match[4], 'port' => $match[5] * 256 + $match[6]);
 
-			// If it's not 227, we weren't given an IP and port, which means it failed.
-			if (substr($response, 0, 4) != '227 ')
-			{
-				$this->error = 'bad_response';
-				return false;
-			}
+		return true;
+	}
 
-			// Snatch the IP and port information, or die horribly trying...
-			if (preg_match('~\((\d+),\s*(\d+),\s*(\d+),\s*(\d+),\s*(\d+)(?:,\s*(\d+))\)~', $response, $match) == 0)
-			{
-				$this->error = 'bad_response';
-				return false;
-			}
+	public function create_file($ftp_file)
+	{
+		// First, we have to be connected... very important.
+		if (!is_resource($this->connection))
+			return false;
+
+		// I'd like one passive mode, please!
+		if (!$this->passive())
+			return false;
 
-			// This is pretty simple - store it for later use ;).
-			$this->pasv = array('ip' => $match[1] . '.' . $match[2] . '.' . $match[3] . '.' . $match[4], 'port' => $match[5] * 256 + $match[6]);
+		// Seems logical enough, so far...
+		fwrite($this->connection, 'STOR ' . $ftp_file . "\r\n");
 
-			return true;
+		// Okay, now we connect to the data port.  If it doesn't work out, it's probably "file already exists", etc.
+		$fp = @fsockopen($this->pasv['ip'], $this->pasv['port'], $err, $err, 5);
+		if (!$fp || !$this->check_response(150))
+		{
+			$this->error = 'bad_file';
+			@fclose($fp);
+			return false;
 		}
 
-		public function create_file($ftp_file)
+		// This may look strange, but we're just closing it to indicate a zero-byte upload.
+		fclose($fp);
+		if (!$this->check_response(226))
 		{
-			// First, we have to be connected... very important.
-			if (!is_resource($this->connection))
-				return false;
+			$this->error = 'bad_response';
+			return false;
+		}
 
-			// I'd like one passive mode, please!
-			if (!$this->passive())
-				return false;
+		return true;
+	}
 
-			// Seems logical enough, so far...
-			fwrite($this->connection, 'STOR ' . $ftp_file . "\r\n");
+	public function list_dir($ftp_path = '', $search = false)
+	{
+		// Are we even connected...?
+		if (!is_resource($this->connection))
+			return false;
 
-			// Okay, now we connect to the data port.  If it doesn't work out, it's probably "file already exists", etc.
-			$fp = @fsockopen($this->pasv['ip'], $this->pasv['port'], $err, $err, 5);
-			if (!$fp || !$this->check_response(150))
-			{
-				$this->error = 'bad_file';
-				@fclose($fp);
-				return false;
-			}
+		// Passive... non-agressive...
+		if (!$this->passive())
+			return false;
 
-			// This may look strange, but we're just closing it to indicate a zero-byte upload.
-			fclose($fp);
-			if (!$this->check_response(226))
-			{
-				$this->error = 'bad_response';
-				return false;
-			}
+		// Get the listing!
+		fwrite($this->connection, 'LIST -1' . ($search ? 'R' : '') . ($ftp_path == '' ? '' : ' ' . $ftp_path) . "\r\n");
 
-			return true;
+		// Connect, assuming we've got a connection.
+		$fp = @fsockopen($this->pasv['ip'], $this->pasv['port'], $err, $err, 5);
+		if (!$fp || !$this->check_response(array(150, 125)))
+		{
+			$this->error = 'bad_response';
+			@fclose($fp);
+			return false;
 		}
 
-		public function list_dir($ftp_path = '', $search = false)
+		// Read in the file listing.
+		$data = '';
+		while (!feof($fp))
+			$data .= fread($fp, 4096);
+		fclose($fp);
+
+		// Everything go okay?
+		if (!$this->check_response(226))
 		{
-			// Are we even connected...?
-			if (!is_resource($this->connection))
-				return false;
+			$this->error = 'bad_response';
+			return false;
+		}
 
-			// Passive... non-agressive...
-			if (!$this->passive())
-				return false;
+		return $data;
+	}
 
-			// Get the listing!
-			fwrite($this->connection, 'LIST -1' . ($search ? 'R' : '') . ($ftp_path == '' ? '' : ' ' . $ftp_path) . "\r\n");
+	public function locate($file, $listing = null)
+	{
+		if ($listing === null)
+			$listing = $this->list_dir('', true);
+		$listing = explode("\n", $listing);
+
+		@fwrite($this->connection, 'PWD' . "\r\n");
+		$time = time();
+		do
+			$response = fgets($this->connection, 1024);
+		while ($response[3] != ' ' && time() - $time < 5);
+
+		// Check for 257!
+		if (preg_match('~^257 "(.+?)" ~', $response, $match) != 0)
+			$current_dir = strtr($match[1], array('""' => '"'));
+		else
+			$current_dir = '';
 
-			// Connect, assuming we've got a connection.
-			$fp = @fsockopen($this->pasv['ip'], $this->pasv['port'], $err, $err, 5);
-			if (!$fp || !$this->check_response(array(150, 125)))
+		for ($i = 0, $n = count($listing); $i < $n; $i++)
+		{
+			if (trim($listing[$i]) == '' && isset($listing[$i + 1]))
 			{
-				$this->error = 'bad_response';
-				@fclose($fp);
-				return false;
+				$current_dir = substr(trim($listing[++$i]), 0, -1);
+				$i++;
 			}
 
-			// Read in the file listing.
-			$data = '';
-			while (!feof($fp))
-				$data .= fread($fp, 4096);
-			fclose($fp);
+			// Okay, this file's name is:
+			$listing[$i] = $current_dir . '/' . trim(strlen($listing[$i]) > 30 ? strrchr($listing[$i], ' ') : $listing[$i]);
 
-			// Everything go okay?
-			if (!$this->check_response(226))
-			{
-				$this->error = 'bad_response';
-				return false;
-			}
-
-			return $data;
+			if ($file[0] == '*' && substr($listing[$i], -(strlen($file) - 1)) == substr($file, 1))
+				return $listing[$i];
+			if (substr($file, -1) == '*' && substr($listing[$i], 0, strlen($file) - 1) == substr($file, 0, -1))
+				return $listing[$i];
+			if (basename($listing[$i]) == $file || $listing[$i] == $file)
+				return $listing[$i];
 		}
 
-		public function locate($file, $listing = null)
-		{
-			if ($listing === null)
-				$listing = $this->list_dir('', true);
-			$listing = explode("\n", $listing);
-
-			@fwrite($this->connection, 'PWD' . "\r\n");
-			$time = time();
-			do
-				$response = fgets($this->connection, 1024);
-			while ($response[3] != ' ' && time() - $time < 5);
-
-			// Check for 257!
-			if (preg_match('~^257 "(.+?)" ~', $response, $match) != 0)
-				$current_dir = strtr($match[1], array('""' => '"'));
-			else
-				$current_dir = '';
-
-			for ($i = 0, $n = count($listing); $i < $n; $i++)
-			{
-				if (trim($listing[$i]) == '' && isset($listing[$i + 1]))
-				{
-					$current_dir = substr(trim($listing[++$i]), 0, -1);
-					$i++;
-				}
-
-				// Okay, this file's name is:
-				$listing[$i] = $current_dir . '/' . trim(strlen($listing[$i]) > 30 ? strrchr($listing[$i], ' ') : $listing[$i]);
-
-				if ($file[0] == '*' && substr($listing[$i], -(strlen($file) - 1)) == substr($file, 1))
-					return $listing[$i];
-				if (substr($file, -1) == '*' && substr($listing[$i], 0, strlen($file) - 1) == substr($file, 0, -1))
-					return $listing[$i];
-				if (basename($listing[$i]) == $file || $listing[$i] == $file)
-					return $listing[$i];
-			}
+		return false;
+	}
 
+	public function create_dir($ftp_dir)
+	{
+		// We must be connected to the server to do something.
+		if (!is_resource($this->connection))
 			return false;
-		}
 
-		public function create_dir($ftp_dir)
+		// Make this new beautiful directory!
+		fwrite($this->connection, 'MKD ' . $ftp_dir . "\r\n");
+		if (!$this->check_response(257))
 		{
-			// We must be connected to the server to do something.
-			if (!is_resource($this->connection))
-				return false;
+			$this->error = 'bad_file';
+			return false;
+		}
 
-			// Make this new beautiful directory!
-			fwrite($this->connection, 'MKD ' . $ftp_dir . "\r\n");
-			if (!$this->check_response(257))
-			{
-				$this->error = 'bad_file';
-				return false;
-			}
+		return true;
+	}
 
-			return true;
-		}
+	public function detect_path($filesystem_path, $lookup_file = null)
+	{
+		$username = '';
 
-		public function detect_path($filesystem_path, $lookup_file = null)
+		if (isset($_SERVER['DOCUMENT_ROOT']))
 		{
-			$username = '';
-
-			if (isset($_SERVER['DOCUMENT_ROOT']))
+			if (preg_match('~^/home[2]?/([^/]+?)/public_html~', $_SERVER['DOCUMENT_ROOT'], $match))
 			{
-				if (preg_match('~^/home[2]?/([^/]+?)/public_html~', $_SERVER['DOCUMENT_ROOT'], $match))
-				{
-					$username = $match[1];
+				$username = $match[1];
 
-					$path = strtr($_SERVER['DOCUMENT_ROOT'], array('/home/' . $match[1] . '/' => '', '/home2/' . $match[1] . '/' => ''));
+				$path = strtr($_SERVER['DOCUMENT_ROOT'], array('/home/' . $match[1] . '/' => '', '/home2/' . $match[1] . '/' => ''));
 
-					if (substr($path, -1) == '/')
-						$path = substr($path, 0, -1);
+				if (substr($path, -1) == '/')
+					$path = substr($path, 0, -1);
 
-					if (strlen(dirname($_SERVER['PHP_SELF'])) > 1)
-						$path .= dirname($_SERVER['PHP_SELF']);
-				}
-				elseif (substr($filesystem_path, 0, 9) == '/var/www/')
-					$path = substr($filesystem_path, 8);
-				else
-					$path = strtr(strtr($filesystem_path, array('\\' => '/')), array($_SERVER['DOCUMENT_ROOT'] => ''));
+				if (strlen(dirname($_SERVER['PHP_SELF'])) > 1)
+					$path .= dirname($_SERVER['PHP_SELF']);
 			}
+			elseif (substr($filesystem_path, 0, 9) == '/var/www/')
+				$path = substr($filesystem_path, 8);
 			else
-				$path = '';
-
-			if (is_resource($this->connection) && $this->list_dir($path) == '')
-			{
-				$data = $this->list_dir('', true);
+				$path = strtr(strtr($filesystem_path, array('\\' => '/')), array($_SERVER['DOCUMENT_ROOT'] => ''));
+		}
+		else
+			$path = '';
 
-				if ($lookup_file === null)
-					$lookup_file = $_SERVER['PHP_SELF'];
+		if (is_resource($this->connection) && $this->list_dir($path) == '')
+		{
+			$data = $this->list_dir('', true);
 
-				$found_path = dirname($this->locate('*' . basename(dirname($lookup_file)) . '/' . basename($lookup_file), $data));
-				if ($found_path == false)
-					$found_path = dirname($this->locate(basename($lookup_file)));
-				if ($found_path != false)
-					$path = $found_path;
-			}
-			elseif (is_resource($this->connection))
-				$found_path = true;
+			if ($lookup_file === null)
+				$lookup_file = $_SERVER['PHP_SELF'];
 
-			return array($username, $path, isset($found_path));
+			$found_path = dirname($this->locate('*' . basename(dirname($lookup_file)) . '/' . basename($lookup_file), $data));
+			if ($found_path == false)
+				$found_path = dirname($this->locate(basename($lookup_file)));
+			if ($found_path != false)
+				$path = $found_path;
 		}
+		elseif (is_resource($this->connection))
+			$found_path = true;
 
-		public function close()
-		{
-			// Goodbye!
-			fwrite($this->connection, 'QUIT' . "\r\n");
-			fclose($this->connection);
+		return array($username, $path, isset($found_path));
+	}
 
-			return true;
-		}
+	public function close()
+	{
+		// Goodbye!
+		fwrite($this->connection, 'QUIT' . "\r\n");
+		fclose($this->connection);
+
+		return true;
 	}
 }
 

+ 40 - 41
Sources/DbExtra-mysql.php

@@ -1,6 +1,8 @@
 <?php
 
 /**
+ * This file contains rarely used extended database functionality.
+ *
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -14,41 +16,9 @@
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	This file contains rarely used extended database functionality.
-
-	void db_extra_init()
-		- add this file's functions to the $smcFunc array.
-
-	resource smf_db_backup_table($table, $backup_table)
-		- backup $table to $backup_table.
-		- returns the request handle to the table creation query
-
-	string function smf_db_get_version()
-		- get the version number.
-
-	string db_insert_sql(string table_name)
-		- gets all the necessary INSERTs for the table named table_name.
-		- goes in 250 row segments.
-		- returns the query to insert the data back in.
-		- returns an empty string if the table was empty.
-
-	array smf_db_list_tables($db = false, $filter = false)
-		- lists all tables in the database
-		- could be filtered according to $filter
-		- returns an array of table names. (strings)
-
-	float smf_db_optimize_table($table)
-		- optimize a table
-		- $table - the table to be optimized
-		- returns how much it was gained
-
-	string db_table_sql(string table_name)
-		- dumps the CREATE for the specified table. (by table_name.)
-		- returns the CREATE statement.
-
-*/
-
-// Add the file functions to the $smcFunc array.
+/**
+ * Add the functions implemented in this file to the $smcFunc array.
+ */
 function db_extra_init()
 {
 	global $smcFunc;
@@ -64,7 +34,12 @@ function db_extra_init()
 		);
 }
 
-// Backup $table to $backup_table.
+/**
+ * Backup $table to $backup_table.
+ * @param $table string
+ * @param $backup_table string
+ * @return resource -the request handle to the table creation query
+ */
 function smf_db_backup_table($table, $backup_table)
 {
 	global $smcFunc, $db_prefix;
@@ -192,7 +167,11 @@ function smf_db_backup_table($table, $backup_table)
 	return $request;
 }
 
-// Optimize a table - return data freed!
+/**
+ * This function optimizes a table.
+ * @param $table string - the table to be optimized
+ * @return how much it was gained
+ */
 function smf_db_optimize_table($table)
 {
 	global $smcFunc, $db_name, $db_prefix;
@@ -234,7 +213,13 @@ function smf_db_optimize_table($table)
 	return $total_change;
 }
 
-// List all the tables in the database.
+/**
+ * This function lists all tables in the database.
+ * The listing could be filtered according to $filter.
+ * @param $db mixed, string holding the table name, or false, default false
+ * @param $filter mixed, string to filter by, or false, default false
+ * @return array, an array of table names. (strings)
+ */
 function smf_db_list_tables($db = false, $filter = false)
 {
 	global $db_name, $smcFunc;
@@ -260,7 +245,13 @@ function smf_db_list_tables($db = false, $filter = false)
 	return $tables;
 }
 
-// Get the content (INSERTs) for a table.
+/**
+ * Gets all the necessary INSERTs for the table named table_name.
+ * It goes in 250 row segments.
+ * @param $tableName string - the table to create the inserts for.
+ * @return string, the query to insert the data back in, or an empty
+ *  string if the table was empty.
+ */
 function smf_db_insert_sql($tableName)
 {
 	global $smcFunc, $db_prefix;
@@ -329,7 +320,12 @@ function smf_db_insert_sql($tableName)
 	return $num_rows == 0 ? '' : $data;
 }
 
-// Get the schema (CREATE) for a table.
+/**
+ * Dumps the schema (CREATE) for a table.
+ * @todo why is this needed for?
+ * @param $tableName string - the table
+ * @return string - the CREATE statement as string
+ */
 function smf_db_table_sql($tableName)
 {
 	global $smcFunc, $db_prefix;
@@ -435,7 +431,10 @@ function smf_db_table_sql($tableName)
 	return $schema_create;
 }
 
-// Get the version number.
+/**
+ *  Get the version number.
+ *  @return string - the version
+ */
 function smf_db_get_version()
 {
 	global $smcFunc;

+ 40 - 41
Sources/DbExtra-postgresql.php

@@ -1,6 +1,8 @@
 <?php
 
 /**
+ * This file contains rarely used extended database functionality.
+ *
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -14,41 +16,9 @@
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	This file contains rarely used extended database functionality.
-
-	void db_extra_init()
-		- add this file's functions to the $smcFunc array.
-
-	resource smf_db_backup_table($table, $backup_table)
-		- backup $table to $backup_table.
-		- returns the request handle to the table creation query
-
-	string function smf_db_get_version()
-		- get the version number.
-
-	string db_insert_sql(string table_name)
-		- gets all the necessary INSERTs for the table named table_name.
-		- goes in 250 row segments.
-		- returns the query to insert the data back in.
-		- returns an empty string if the table was empty.
-
-	array smf_db_list_tables($db = false, $filter = false)
-		- lists all tables in the database
-		- could be filtered according to $filter
-		- returns an array of table names. (strings)
-
-	float smf_db_optimize_table($table)
-		- optimize a table
-		- $table - the table to be optimized
-		- returns how much it was gained
-
-	string db_table_sql(string table_name)
-		- dumps the CREATE for the specified table. (by table_name.)
-		- returns the CREATE statement.
-
-*/
-
-// Add the file functions to the $smcFunc array.
+/**
+ * Add the functions implemented in this file to the $smcFunc array.
+ */
 function db_extra_init()
 {
 	global $smcFunc;
@@ -64,7 +34,12 @@ function db_extra_init()
 		);
 }
 
-// Backup $table to $backup_table.
+/**
+ * Backup $table to $backup_table.
+ * @param $table string
+ * @param $backup_table string
+ * @return resource -the request handle to the table creation query
+ */
 function smf_db_backup_table($table, $backup_table)
 {
 	global $smcFunc, $db_prefix;
@@ -103,7 +78,11 @@ function smf_db_backup_table($table, $backup_table)
 	);
 }
 
-// Optimize a table - return data freed!
+/**
+ * This function optimizes a table.
+ * @param $table string - the table to be optimized
+ * @return how much it was gained
+ */
 function smf_db_optimize_table($table)
 {
 	global $smcFunc, $db_prefix;
@@ -128,7 +107,13 @@ function smf_db_optimize_table($table)
 		return 0;
 }
 
-// List all the tables in the database.
+/**
+ * This function lists all tables in the database.
+ * The listing could be filtered according to $filter.
+ * @param $db mixed, string holding the table name, or false, default false
+ * @param $filter mixed, string to filter by, or false, default false
+ * @return array, an array of table names. (strings)
+ */
 function smf_db_list_tables($db = false, $filter = false)
 {
 	global $smcFunc;
@@ -153,7 +138,13 @@ function smf_db_list_tables($db = false, $filter = false)
 	return $tables;
 }
 
-// Get the content (INSERTs) for a table.
+/**
+ * Gets all the necessary INSERTs for the table named table_name.
+ * It goes in 250 row segments.
+ * @param $tableName string - the table to create the inserts for.
+ * @return string, the query to insert the data back in, or an empty
+ *  string if the table was empty.
+ */
 function smf_db_insert_sql($tableName)
 {
 	global $smcFunc, $db_prefix;
@@ -210,7 +201,12 @@ function smf_db_insert_sql($tableName)
 	return $num_rows == 0 ? '' : $data;
 }
 
-// Get the schema (CREATE) for a table.
+/**
+ * Dumps the schema (CREATE) for a table.
+ * @todo why is this needed for?
+ * @param $tableName string - the table
+ * @return string - the CREATE statement as string
+ */
 function smf_db_table_sql($tableName)
 {
 	global $smcFunc, $db_prefix;
@@ -309,7 +305,10 @@ function smf_db_table_sql($tableName)
 	return $seq_create . $schema_create . $index_create;
 }
 
-// Get the version number.
+/**
+ *  Get the version number.
+ *  @return string - the version
+ */
 function smf_db_get_version()
 {
 	global $smcFunc;

+ 44 - 42
Sources/DbExtra-sqlite.php

@@ -1,6 +1,8 @@
 <?php
 
 /**
+ * This file contains rarely used extended database functionality.
+ * 
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -14,41 +16,9 @@
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	This file contains rarely used extended database functionality.
-
-	void db_extra_init()
-		- add this file's functions to the $smcFunc array.
-
-	resource smf_db_backup_table($table, $backup_table)
-		- backup $table to $backup_table.
-		- returns the request handle to the table creation query
-
-	string function smf_db_get_version()
-		- get the version number.
-
-	string db_insert_sql(string table_name)
-		- gets all the necessary INSERTs for the table named table_name.
-		- goes in 250 row segments.
-		- returns the query to insert the data back in.
-		- returns an empty string if the table was empty.
-
-	array smf_db_list_tables($db = false, $filter = false)
-		- lists all tables in the database
-		- could be filtered according to $filter
-		- returns an array of table names. (strings)
-
-	float smf_db_optimize_table($table)
-		- optimize a table
-		- $table - the table to be optimized
-		- returns how much it was gained
-
-	string db_table_sql(string table_name)
-		- dumps the CREATE for the specified table. (by table_name.)
-		- returns the CREATE statement.
-
-*/
-
-// Add the file functions to the $smcFunc array.
+/**
+ * Add the functions implemented in this file to the $smcFunc array.
+ */
 function db_extra_init()
 {
 	global $smcFunc;
@@ -65,7 +35,12 @@ function db_extra_init()
 		);
 }
 
-// Backup $table to $backup_table.
+/**
+ * Backup $table to $backup_table.
+ * @param $table string
+ * @param $backup_table string
+ * @return resource -the request handle to the table creation query
+ */
 function smf_db_backup_table($table, $backup_table)
 {
 	global $smcFunc, $db_prefix;
@@ -153,7 +128,11 @@ function smf_db_backup_table($table, $backup_table)
 	return $request;
 }
 
-// Optimize a table - return data freed!
+/**
+ * This function optimizes a table.
+ * @param $table string - the table to be optimized
+ * @return how much it was gained
+ */
 function smf_db_optimize_table($table)
 {
 	global $smcFunc, $db_prefix;
@@ -176,7 +155,13 @@ function smf_db_optimize_table($table)
 	return 0;
 }
 
-// List all the tables in the database.
+/**
+ * This function lists all tables in the database.
+ * The listing could be filtered according to $filter.
+ * @param $db mixed, string holding the table name, or false, default false
+ * @param $filter mixed, string to filter by, or false, default false
+ * @return array, an array of table names. (strings)
+ */
 function smf_db_list_tables($db = false, $filter = false)
 {
 	global $smcFunc;
@@ -202,7 +187,13 @@ function smf_db_list_tables($db = false, $filter = false)
 	return $tables;
 }
 
-// Get the content (INSERTs) for a table.
+/**
+ * Gets all the necessary INSERTs for the table named table_name.
+ * It goes in 250 row segments.
+ * @param $tableName string - the table to create the inserts for.
+ * @return string, the query to insert the data back in, or an empty
+ *  string if the table was empty.
+ */
 function smf_db_insert_sql($tableName)
 {
 	global $smcFunc, $db_prefix;
@@ -262,7 +253,12 @@ function smf_db_insert_sql($tableName)
 	return $num_rows == 0 ? '' : $data . 'COMMIT;' . $crlf;
 }
 
-// Get the schema (CREATE) for a table.
+/**
+ * Dumps the schema (CREATE) for a table.
+ * @todo why is this needed for?
+ * @param $tableName string - the table
+ * @return string - the CREATE statement as string
+ */
 function smf_db_table_sql($tableName)
 {
 	global $smcFunc, $db_prefix;
@@ -313,13 +309,19 @@ function smf_db_table_sql($tableName)
 	return $schema_create . $index_create;
 }
 
-// Get the version number.
+/**
+ *  Get the version number.
+ *  @return string - the version
+ */
 function smf_db_get_version()
 {
 	return sqlite_libversion();
 }
 
-// Simple return the database - and die!
+/** 
+ * Simply return the database - and die!
+ * Used by DumpDatabase.php.
+ */
 function smf_db_get_backup()
 {
 	global $db_name;

+ 11 - 14
Sources/DumpDatabase.php

@@ -1,6 +1,8 @@
 <?php
 
 /**
+ * This file has a single job - database backup.
+ *
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -14,20 +16,15 @@
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*
-	This file has a single job - database backup.
-
-	void DumpDatabase2()
-		- writes all of the database to standard output.
-		- uses gzip compression if compress is set in the URL/post data.
-		- may possibly time out in some cases.
-		- the data dumped depends on whether "struct" and "data" are passed.
-		- requires an administrator and the session hash by post.
-		- is called from ManageMaintenance.php.
-
-*/
-
-// Dumps the database to a file.
+/**
+ * Dumps the database.
+ * It writes all of the database to standard output.
+ * It uses gzip compression if compress is set in the URL/post data.
+ * It may possibly time out, and mess up badly if you were relying on it. :P
+ * The data dumped depends on whether "struct" and "data" are passed.
+ * It requires an administrator and the session hash by post.
+ * It is called from ManageMaintenance.php.
+ */
 function DumpDatabase2()
 {
 	global $db_name, $scripturl, $context, $modSettings, $crlf, $smcFunc, $db_prefix;

+ 43 - 9
Sources/Subs-Compat.php

@@ -1,6 +1,11 @@
 <?php
 
 /**
+ * This file provides compatibility functions and code for older versions of
+ * PHP, such as the sha1() function, missing extensions, or 64-bit vs 32-bit
+ * systems. It is only included for those older versions or when the respective
+ * extension or function cannot be found.
+ * 
  * Simple Machines Forum (SMF)
  *
  * @package SMF
@@ -14,11 +19,6 @@
 if (!defined('SMF'))
 	die('Hacking attempt...');
 
-/*	This file provides compatibility functions and code for older versions of
-	PHP, such as the sha1() function.  It is only included for those older
-	versions.
-*/
-
 if (!function_exists('stripos'))
 {
 	function stripos($haystack, $needle, $offset = 0)
@@ -36,9 +36,13 @@ if (!function_exists('md5_file'))
 	}
 }
 
-// Split a string into an array.
 if (!function_exists('str_split'))
 {
+	/**
+	 * Split a string into an array.
+	 * @param $str the string to split
+	 * @param $str_length 
+	 */
 	function str_split($str, $str_length = 1)
 	{
 		if ($str_length < 1)
@@ -86,7 +90,10 @@ if (!function_exists('file_get_contents'))
 	}
 }
 
-// Define the old SMF sha1 function.
+/**
+ * Define the old SMF sha1 function.
+ * @param $str the string
+ */
 function sha1_smf($str)
 {
 	// If we have mhash loaded in, use it instead!
@@ -104,7 +111,9 @@ function sha1_smf($str)
 	return sha1_core($blks, strlen($str) * 8);
 }
 
-// This is the core SHA-1 calculation routine, used by sha1().
+/**
+ * This is the core SHA-1 calculation routine, used by sha1().
+ */
 function sha1_core($x, $len)
 {
 	@$x[$len >> 5] |= 0x80 << (24 - $len % 32);
@@ -178,7 +187,9 @@ function sha1_rol($num, $cnt)
 	return ($num << $cnt) | $a;
 }
 
-// Still on old PHP - bad boy! (the built in one would be faster.)
+/**
+ * Still on old PHP - bad boy! (the built in one would be faster.)
+ */
 if (!function_exists('sha1'))
 {
 	function sha1($str)
@@ -240,4 +251,27 @@ if (!function_exists('mysql_real_escape_string'))
 	}
 }
 
+if (!function_exists('smf_crc32'))
+{
+	/**
+	 * Compatibility function.
+	 * crc32 doesn't work as expected on 64-bit functions - make our own.
+	 * http://www.php.net/crc32#79567
+	 * @param $number
+	 */
+	function smf_crc32($number)
+	{
+		$crc = crc32($number);
+
+		if ($crc & 0x80000000)
+		{
+			$crc ^= 0xffffffff;
+			$crc += 1;
+			$crc = -$crc;
+		}
+
+		return $crc;
+	}
+}
+
 ?>