Browse Source

These optimizations seems not so useful nowadays

Signed-off-by: emanuele <[email protected]>
emanuele 11 years ago
parent
commit
e9eed6ed90
1 changed files with 8 additions and 8 deletions
  1. 8 8
      Sources/Load.php

+ 8 - 8
Sources/Load.php

@@ -952,10 +952,10 @@ function loadMemberData($users, $is_name = false, $set = 'normal')
 		$request = $smcFunc['db_query']('', '
 			SELECT' . $select_columns . '
 			FROM {db_prefix}members AS mem' . $select_tables . '
-			WHERE mem.' . ($is_name ? 'member_name' : 'id_member') . (count($users) == 1 ? ' = {' . ($is_name ? 'string' : 'int') . ':users}' : ' IN ({' . ($is_name ? 'array_string' : 'array_int') . ':users})'),
+			WHERE mem.' . ($is_name ? 'member_name' : 'id_member') . ' IN ({' . ($is_name ? 'array_string' : 'array_int') . ':users})',
 			array(
 				'blank_string' => '',
-				'users' => count($users) == 1 ? current($users) : $users,
+				'users' => $users,
 			)
 		);
 		$new_loaded_ids = array();
@@ -974,9 +974,9 @@ function loadMemberData($users, $is_name = false, $set = 'normal')
 		$request = $smcFunc['db_query']('', '
 			SELECT *
 			FROM {db_prefix}themes
-			WHERE id_member' . (count($new_loaded_ids) == 1 ? ' = {int:loaded_ids}' : ' IN ({array_int:loaded_ids})'),
+			WHERE id_member IN ({array_int:loaded_ids})',
 			array(
-				'loaded_ids' => count($new_loaded_ids) == 1 ? $new_loaded_ids[0] : $new_loaded_ids,
+				'loaded_ids' => $new_loaded_ids,
 			)
 		);
 		while ($row = $smcFunc['db_fetch_assoc']($request))
@@ -1267,11 +1267,11 @@ function loadMemberCustomFields($users, $params)
 		c.show_display, c.show_profile, c.private, c.active, c.bbc, c.can_search, c.default_value, c.enclose, c.placement, t.variable, t.value, t.id_member
 		FROM {db_prefix}themes AS t
 			LEFT JOIN {db_prefix}custom_fields AS c ON (c.col_name = t.variable)
-		WHERE id_member' . (count($users) == 1 ? ' = {int:loaded_ids} ' : ' IN ({array_int:loaded_ids}) ') .
-			'AND variable' . (count($params) == 1 ? ' = {string:params}' : ' IN ({array_string:params})'),
+		WHERE id_member IN ({array_int:loaded_ids}) 
+			AND variable IN ({array_string:params})'),
 		array(
-			'loaded_ids' => (int) count($users) == 1 ? $users[0] : $users,
-			'params' => (string) count($params) == 1 ? $params[0] : $params,
+			'loaded_ids' => $users,
+			'params' => $params,
 		)
 	);