Browse Source

hopefully fixed bug, function was taking wrong argumetns

digital 8 years ago
parent
commit
2d9ef387f0
1 changed files with 5 additions and 9 deletions
  1. 5 9
      pin/__init__.py

+ 5 - 9
pin/__init__.py

@@ -53,7 +53,7 @@ def _parse_to_int_list(parse):
         parse.append(int(part))
     return parse
 
-def _output(self,pins,state):
+def _output(pins,state):
     lpin.debug("setting pin(s) {:0>2} to value {}".format(
         pins,state))
     _pins_for_cleanup.update(pins)
@@ -109,15 +109,12 @@ class PinBase(object):
     def __init__(self,pin_number):
         super(PinBase,self).__init__()
         self.pin_number = pin_number
-        lpin.debug(self.pin_number)
         self.value = self.value_low
 
     def output(self,value):
         [value] = _parse_to_int_list(value)
         self.value = value
-        lpin.debug(self.pin_number)
-        lpin.debug(value)
-        _output(pins=self.pin_number,state=value)
+        _output(self.pin_number,value)
 
     def read(self):
         value = _read(self.pin_number,value)
@@ -177,8 +174,7 @@ class PCEngine(PinControllerBase):
         self.set_speed(1)
         self.set_state(1)
     def set_speed(self,speed):
-        # self.pin_analog.output(speed)
-        PinBase.output(self,speed)
+        self.pin_analog.output(speed)
         self.speed = speed
     def set_state(self,state):
         """state is integer and specifies if the engine should be turned on (1) or turned off (0) """
@@ -260,9 +256,9 @@ class LED(DigitalPin):
         gpio.setup(pin,gpio.OUT)
         self.on()
     def on(self,args=[],command=None,respond=None):
-        _output(5,1)
+        self.output(True)
     def off(self,args=[],command=None,respond=None):
-        self.output(0)
+        self.output(False)
     def set(self,args=[],command=None,respond=None):
         if len(args) != 1:
             respond("one missing argument: state")